Nbgrader refactor - Githubissues

jupyterhub / jupyterhub-deploy-teaching

Reference deployment of JupyterHub and nbgrader on a single server

http://jupyterhub-deploy-teaching.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

247 stars 85 forks source link

Nbgrader refactor #51

Closed ellisonbg closed 7 years ago

ellisonbg commented 7 years ago

Here is a PR that refactors the ansible stuff for nbgrader:

Uses nbgrader's new approach to installing nbextension's and serverextension (just use the regular jupyter commands).
Allows for multiple formgrade instances.

I still need to test this on my deployment before we merge...

ellisonbg commented 7 years ago

@jhamrick

ellisonbg commented 7 years ago

Right now master is broken...going to merge this and iterate/fix things along the way...

randy3k commented 7 years ago

How should I access formgrade with this PR? I tried https://www.example.com/services/formgrader-course101 but it doesn't work.

randy3k commented 7 years ago

Oh, it should be https://www.example.com/services/formgrade-course101 instead of formgrader

Somehow, it is not consistent with nbgrader documentation https://nbgrader.readthedocs.io/en/stable/configuration/jupyterhub_config.html

willingc commented 7 years ago

Hi @randy3k!

Thanks for the question and I'm glad you solved your question. Technically, the Ansible scripts here as a specific deployment and the more general nbgrader documentation are both correct. Yet, I agree with you that the inconsistent naming is confusing. Thanks for pointing that out in the documentation. If you find other parts of the docs confusing, please do let us know.

@jhamrick, Do you want me to do a PR to update the nbgrader docs?

jhamrick commented 7 years ago

@willingc yes, that would be awesome, thank you!