add options to cull named servers and default servers separately

jupyterhub / jupyterhub-idle-culler

JupyterHub service to cull idle servers and users

Other

101 stars 37 forks source link

add options to cull named servers and default servers separately #74

Closed HCharlie closed 3 months ago

HCharlie commented 6 months ago

addressing issue, add options to cull named servers only and default servers only

Fixes https://github.com/jupyterhub/jupyterhub-idle-culler/issues/73

welcome[bot] commented 6 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

yuvipanda commented 3 months ago

Apologies for the late review, @HCharlie! I think this looks good, I made a minor change to help clarify the code a little more. Going to merge now.