Vendor favicons and logos instead of using a CDN for them

jupyterhub / jupyterhub-sphinx-theme

A lightweight wrapper theme for Sphinx based on the PyData Sphinx Theme

https://jupyterhub-sphinx-theme.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Vendor favicons and logos instead of using a CDN for them #3

Open consideRatio opened 1 year ago

consideRatio commented 1 year ago

I saw this reference:

https://github.com/choldgraf/jupyterhub-sphinx-theme/blob/f97104c11cae55869ddc8394eb83594bd5c7d075/src/jupyterhub_sphinx_theme/__init__.py#L17-L21

Should we host this logo ourselves somewhere? But if so, where?

choldgraf commented 1 year ago

we could vendor it with this package I think, would that work?

consideRatio commented 1 year ago

Ah, sounds like a good choice if we can make it possible technically!

manics commented 1 year ago

Ideally this theme should be usable by people who block cross-domain resource requests- I've met quite a few developers who do this. This also means this theme would work in security focussed enterprise environments with strict firewalls.