search

jupyterhub / jupyterlab-hub

Deprecated: JupyterLab extension for running JupyterLab with JupyterHub
BSD 3-Clause "New" or "Revised" License
181 stars 40 forks source link

window.open(..., _self) instead of _blank #48

Closed TimKreuzer closed 6 years ago

TimKreuzer commented 6 years ago

Hey, first of all: thanks for this awesome extension. Is it possible to add an option, in which tab the control panel / logout will be opened? When pressing Logout my JupyterHub stops the users running JupyterLab. But with the tab still in the background, you will get a few errors, because the JupyterLab is not running anymore (but the browser tries to interact with it).

When this line https://github.com/jupyterhub/jupyterlab-hub/blob/9929330ee05eb074bc25c0469b7bf9f2aed6705a/src/index.ts#L62 (and line 82) would call window.open(..., _self) instead of _blank my problem would be solved.

Is it possible to add a kind of settings to define this?

Thanks and Best regards, Tim

madx commented 6 years ago

I second this issue, the behavior here is confusing as I can still continue to interact with my JupyterLab session after having logged out :frowning: