search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
549 stars 305 forks source link

Add stop_timeout instead of re-using start_timeout #253

Open elgalu opened 6 years ago

elgalu commented 6 years ago

I think it would be better to add stop_timeout instead of re-using start_timeout here:

https://github.com/jupyterhub/kubespawner/blob/5040e75022f302b3cbfadaa1ae18a5ab9d5563a0/kubespawner/spawner.py#L1784

minrk commented 6 years ago

Makes sense

consideRatio commented 4 years ago

Still relevant issue.

https://github.com/jupyterhub/kubespawner/blob/44d638b7c63576b7f88e82e6073de3f2ee2c4116/kubespawner/spawner.py#L2011-L2020