search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
543 stars 304 forks source link

Utilize pyflakes in CI #358

Closed consideRatio closed 4 years ago

consideRatio commented 4 years ago

We realized the benefit of having something like pyflakes to catch basic python errors in https://github.com/jupyterhub/kubespawner/pull/357.

This issue could be closed by updating the CI system to run a pyflake on our python code, and fail on basic errors.

minrk commented 4 years ago

Yes! One point though, flake8 is a better runner for pyflakes because it allows selecting when to apply the checks, # noqa comments, etc. which is useful in CI because pyflakes can complain on valid code and has no configuration.

See the jupyterhub flake8 configuration for an example.