search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
549 stars 305 forks source link

When container fails to start, there is no trace in the jupyterhub logs of the k8s events #397

Open mrow4a opened 4 years ago

mrow4a commented 4 years ago

Currently, we are continuously sending events (https://github.com/jupyterhub/kubespawner/blob/master/kubespawner/spawner.py#L1637), and when spawn is successful, we log them cumulatively in https://github.com/jupyterhub/kubespawner/blob/master/kubespawner/spawner.py#L1843-L1852. However, there is no trace of them in the timeout scenario.

Would it be worth to also log the events to the logs continuously, or at least in crash scenario log them as in success scenario? We could contribute with implementation if something is agreed.

consideRatio commented 4 years ago

@mrow4a I'm issue triaging and struggle a bit to follow this issue, can you help clarify it?

  1. Can you update the links so they don't point to the right lines, and use a permalink so they don't get outdated.
  2. Can you clarify whenever you mean a k8s Event and a JupyterHub Spawner progress event?