jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
546 stars 304 forks source link

Save dns_name between restarts #677

Closed dolfinus closed 1 year ago

dolfinus commented 1 year ago

In #657 a change with saving and restoring the namespace was added to KubeSpawner, to avoid some issues caused by Jupyterhub restart. But namespace is substituted in dns_name_template, so dns_name should be saved and restored as well.

Other options in __init__ support only hubnamespace substutution, not pod namespace, so there is no need to preserve it between restart.