jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
541 stars 303 forks source link

Enable progress bar progression for singleuser.events = False: #701

Open antonvorobets opened 1 year ago

antonvorobets commented 1 year ago

Proposed change

Change the behavior of singleuser.events = False:. Currently, this option will leave the progress bar empty, which might make users uneasy as it will seem as if nothing is happening until their server is available. See this discourse thread for more information: https://discourse.jupyter.org/t/how-to-deactivate-the-event-log/17082.

The proposal is to let singleuser.events = False: show the progress bar progression, but remove the event log or at least deactivate the duplication of "Server requested".

Alternative options

An option is to overwrite the behavior by subclassing the KubeSpawner as described here: https://discourse.jupyter.org/t/how-to-deactivate-the-event-log/17082/7?u=antonvorobets. However, this has some side effects for the event log and requires cluster admins to keep an eye on the progress() method.

Who would use this feature?

People who don't want their users to see the events when their server is spawned. The messages can be confusing for regular users and there should be no need for them to know, for example, that a node didn’t match a Pod’s node affinity/selector before a scaleup is correctly triggered. Information about the maximum number of nodes, image names and where they are stored also seem to be unnecessary for regular users.

(Optional): Suggest a solution

A part of the solution could simply be to change yield in progress() as described here: https://discourse.jupyter.org/t/how-to-deactivate-the-event-log/17082/7?u=antonvorobets. Currently progress() simply returns None if singleuser.events = False:. I unfortunately don't have sufficient overview of the KubeSpawner to suggest how to adjust the behavior of the event log.

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

antonvorobets commented 10 months ago

I see that this issue was added and then removed in March. Are there any plans to implement this feature or at least improve the messages for the users as suggested in this issue https://github.com/jupyterhub/kubespawner/issues/524?

The current messages are really not helpful for users and cause significant confusion. The messages are good for cluster admins, but having just the progress bar should be sufficient for users. For example, there is no need for users to know the full name of the image being pulled or how many nodes the cluster can scale up to. It also seem to cause unrest when the message says warning, while it just scales up the cluster.