search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
543 stars 304 forks source link

[bufix] Allow POST requests without profile_options specified (defaults will be used) #769

Closed GeorgianaElena closed 1 year ago

GeorgianaElena commented 1 year ago

This is a test that reproduces the bug in https://github.com/jupyterhub/kubespawner/issues/758.

It should help us find the bug by investigating the particularities of this test profile list and also know if we'd fix the bug.

GeorgianaElena commented 1 year ago

I believe the issue was that we were validating user's chosen user_options against the profile's profile_optionseven if the user didn't chose anything, hence user_options was empty.

yuvipanda commented 1 year ago

I just tested this and it works!

consideRatio commented 1 year ago

Nice work identifying this @GeorgianaElena!! This looks good!!

yuvipanda commented 1 year ago

@consideRatio the docstring became out of date after this PR, I opened https://github.com/jupyterhub/kubespawner/pull/771 to update it.