jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
543 stars 304 forks source link

Unlisted choice improvements #776

Closed batpad closed 1 year ago

batpad commented 1 year ago

Towards #756 and #757 -

I might have underestimated the complexity in hiding the select dropdown if there are no choices present, and that bit seems to have gotten a bit ugly. Will leave some comments in the code to see if there's things we can improve.

@yuvipanda @consideRatio @GeorgianaElena - firstly, thank you so much for fixing up issues with the unlisted_choices work, and many apologies for the delay in getting to these fixes. I am not super happy with the implementation in this PR, and I'll leave some more notes with the code. I did a bit of testing though, and it seems to me like it all works as expected.

If this approach seems ok to you all, I think what might be pending:

batpad commented 1 year ago

Oops, my bad - I thought I was up-to-date with kubespawner:main but apparently not. Just going to close with PR and open a new one cleaned up. Apologies for the noise.