search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
536 stars 301 forks source link

fix: unneeded escaping of capital letters in k8s labels #791

Closed byteMuncher0x closed 1 month ago

byteMuncher0x commented 9 months ago

The current version of the Kubespawner escapes all capital letters from labels before they are asigned to K8s resources. This is unnecessary as per the K8s standards.

consideRatio commented 9 months ago

I figure this would have made sense to do initially, at least if we can apply the same ecaping consistently, but to change this now could possibly cause consequences forcing this change to be considered a breaking change. I'm not sure though, what are your thoughts - would this be a breaking change?

yuvipanda commented 9 months ago

Further discussion in https://github.com/jupyterhub/kubespawner/issues/737

yuvipanda commented 1 month ago

Thank you very much for your PR, @byteMuncher0x. Unfortunately this turns out to be more complex and possibly a breaking change. @minrk has picked up this work again in https://github.com/jupyterhub/kubespawner/pull/744, and progress is being made. I invite you to participate in review and suggestions there! But I'm going to close this PR, as it unfortunately will cause a breaking change as is.