search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
531 stars 299 forks source link

Dynamically retrieve podCIDR for routing in CONTRIBUTING #793

Closed yuvipanda closed 9 months ago

yuvipanda commented 9 months ago

The CIDR from which pod IPs are allocated can change depending on platform and driver used for minikube. On my machine, it's 10.244.0.0/24. This changes the instructions to determine the podCIDR dynamically by talking to kubernetes, rather than hardcoding it in.

I personally prefer just repeating the command here rather than using an environment variable, as it means the single line can be just copy pasted.

yuvipanda commented 9 months ago

It would be useful for someone with a different configuration than mine to test this command to make sure it provides appropriate output for you. I'm on Mac OS.

yuvipanda commented 9 months ago

Thanks @minrk :)

consideRatio commented 9 months ago

Wieee thanks for taking the time to work this @yuvipanda and @minrk!!! :heart: :tada:

I added a documentation label for this PR, a small detail that reduces the workload when its time to make a changelog!