Fix #761 expand pvc_name outside of init

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub

https://jupyterhub-kubespawner.readthedocs.io

BSD 3-Clause "New" or "Revised" License

543 stars 304 forks source link

Fix #761 expand pvc_name outside of init #820

Open Ph0tonic opened 8 months ago

Ph0tonic commented 8 months ago

Partial fix for #761 by moving the expansion of pvc_name and secret_name outside of __init__.

\cc @yuvipanda

welcome[bot] commented 8 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

manics commented 8 months ago

I've added the https://github.com/jupyterhub/kubespawner/labels/breaking label since this changes method signatures that may be used by subclasses.