search

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
543 stars 304 forks source link

specify wheel build target for hatch explicitly #832

Closed willh-cmyk closed 5 months ago

willh-cmyk commented 5 months ago

I'm submitting a fix for building wheels for this package.

I'm getting this error when building wheels for my multistage docker build:

ValueError: Unable to determine which files to ship inside the wheel using the following heuristics: https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection

The most likely cause of this is that there is no directory that matches the name of your project (jupyterhub_kubespawner).

At least one file selection option must be defined in the `tool.hatch.build.targets.wheel` table, see: https://hatch.pypa.io/latest/config/build/

As an example, if you intend to ship a directory named `foo` that resides within a `src` directory located at the root of your project, you can define the following:

[tool.hatch.build.targets.wheel]
packages = ["src/foo"]
welcome[bot] commented 5 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

willh-cmyk commented 5 months ago

https://github.com/jupyterhub/kubespawner/issues/831 relevant issue is here

consideRatio commented 5 months ago

Thank you @willh-cmyk! This is a bug I recall running into but never getting down to the details of understanding the fix or what was going on.