Are we testing against JupyterHub 1.3? - Githubissues

jupyterhub / kubespawner

Kubernetes spawner for JupyterHub

https://jupyterhub-kubespawner.readthedocs.io

BSD 3-Clause "New" or "Revised" License

531 stars 299 forks source link

Are we testing against JupyterHub 1.3? #833

Closed consideRatio closed 3 weeks ago

consideRatio commented 2 months ago

It seems we have fixture that creates a jupyterhub pod with the version hardcoded to jupyterhub 1.3.

We should make our tests test against the version of jupyterhub we expect it to be tested against.

https://github.com/jupyterhub/kubespawner/blob/127647ce9f25c75fb2acbea43e1c39fe11fdce7a/tests/conftest.py#L414-L423

https://github.com/jupyterhub/kubespawner/blob/127647ce9f25c75fb2acbea43e1c39fe11fdce7a/.github/workflows/test.yaml#L40-L61

Confusion points for me are currently:

We are installing jupyterhub locally, but we also in our test suite start a jupyterhub pod with version 1.3. How is the hub pod used compared to the local jupyterhub software in our test suite?