Closed sunu closed 1 month ago
@yuvipanda Could you please take a look at these changes and let me know if they look good? If this looks ok, I'll proceed to make similar updates for other traitlets that need to support dictionaries. Thanks!
Thanks for the review @yuvipanda! I have added the missing docstring. I'll open a follow up PR to make similar updates for other traitlets that need to support dictionaries.
Thanks @sunu!
I've made the following changes:
Union(trait_types=[List(), Dict()])
so that they can be defined as dictionaries (for easy overriding) or as lists (for backwards compatibility)Defining these values as dictionaries enables easy overriding. refs https://github.com/jupyterhub/jupyterhub/pull/4822 and https://github.com/NASA-IMPACT/veda-jupyterhub/issues/44