jupyterhub / kubespawner

Kubernetes spawner for JupyterHub
https://jupyterhub-kubespawner.readthedocs.io
BSD 3-Clause "New" or "Revised" License
541 stars 303 forks source link

Allow volumes and volume mounts to be defined as Dicts #843

Closed sunu closed 1 month ago

sunu commented 1 month ago

I've made the following changes:

Defining these values as dictionaries enables easy overriding. refs https://github.com/jupyterhub/jupyterhub/pull/4822 and https://github.com/NASA-IMPACT/veda-jupyterhub/issues/44

sunu commented 1 month ago

@yuvipanda Could you please take a look at these changes and let me know if they look good? If this looks ok, I'll proceed to make similar updates for other traitlets that need to support dictionaries. Thanks!

sunu commented 1 month ago

Thanks for the review @yuvipanda! I have added the missing docstring. I'll open a follow up PR to make similar updates for other traitlets that need to support dictionaries.

yuvipanda commented 1 month ago

Thanks @sunu!