jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
204 stars 177 forks source link

ci: Replace Travis with GitHub workflow #188

Closed manics closed 3 years ago

manics commented 3 years ago

See https://github.com/jupyterhub/team-compass/issues/353

This is based on https://github.com/jupyterhub/oauthenticator/tree/be91e7d9e58f13221615a64a506529c775abe593/.github/workflows

The main changes from the Travis configuration are:

manics commented 3 years ago

This will require PyPI secrets to be setup

consideRatio commented 3 years ago

This LGTM

I'm conflicted about having the test build part of the release workflow as it feels misleading to run a test there, but i'm aware that it would lead to breaking of DRY if we had a dedicated test in the test workflow which isnt great either.

We can't overwork this with our limited maintenance time though and it will be a compromise no matter what and its not sure my preference is most sensible.

If you are ready, lets merge! The pypi password is already setup ahead of time for this repo!