search

jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
202 stars 175 forks source link

Github Actions Gate broken #191

Closed bloodeagle40234 closed 3 years ago

bloodeagle40234 commented 3 years ago

Bug description

Current, upstream master HEAD (https://github.com/jupyterhub/ldapauthenticator/commit/31d70f8420b3c0ffd96d61164e0921bfe2ae431a) cannot pass the github actions workflow because of some errors. (e.g. Connection Reset by Peer, ldap3.core.exceptions.LDAPSocketOpenError, etc...)

Even this repository worked in the past check, it happened with pure HEAD commit with my forked repository (see https://github.com/bloodeagle40234/ldapauthenticator/commit/31d70f8420b3c0ffd96d61164e0921bfe2ae431a and the actions result in detail)

Expected behaviour

All tests should pass if we don't change anything

Actual behaviour

Got LDAP errors. Almost errors seem network errors when trying to connect to testing ldap server.

How to reproduce

  1. Run github actions CI with current HEAD (https://github.com/jupyterhub/ldapauthenticator/commit/31d70f8420b3c0ffd96d61164e0921bfe2ae431a) 1.1 the easiest way is just fork (or push) the master to somewhere in github
bloodeagle40234 commented 3 years ago

Gotta. The breaking change has been in rroemhild/docker-test-openldap container image. That changed the service port from 389/636 to 10389/10636 so that we have to change the docker container port mapping from local 10389/10636 to 389/636 in docker continer.

The breaking change was https://github.com/rroemhild/docker-test-openldap/commit/adb4650727e0123c7c24c7d7ce8609d12384a29b and it was described in the newest docs.