search

jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
202 stars 175 forks source link

Add admin_group to grant admin access to users of these groups #198

Open Vendetta01 opened 3 years ago

Vendetta01 commented 3 years ago

This PR adds a new configuration option admin_groups, to grant admin access to all users that are members of these groups and thus lets you define admin access through ldap group membership. Its implementation is similar to allowed_groups.

This fixes #160.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

firemdkfighter commented 2 years ago

When this PR will be merged?

Yayg commented 2 years ago

:+1: for getting this merged! Thanks for the contribution

mrdrelar commented 2 years ago

plus for this PR. When it will be merged?