search

jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
206 stars 178 forks source link

Add a new option: use_tls #216

Closed loic-vial closed 2 months ago

loic-vial commented 1 year ago

Hello !

Thank you for the work done on this plugin ! I am currently using it for accessing JupyterHub in our data science team at my company, but I needed to add an option "use_tls" and set it to False to actually make it work. That is because we need to connect to a LDAP server that needs this configuration.

For information, such option exists in the LDAP connector used by Airflow, another tool that we are also using. There is distincts "USE_SSL" and "USE_TLS" options for addressing our use case, so I just applied the same logic.

I hope that my PR is correct, I simply added the option "use_tls" and a small test for testing the option. I also needed to update the black pre-commit hook because it didn't work on my computer.

Obviously, the default value of this option does not change anything on the current behavior.

Thank you !

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 months ago

I think this makes sense, it clarifies that actually TLS is used by default as well, but I'm struggling still a bit as there seem to be two ways of handling TLS.

(From googling ldap port tls)

image

This config seems related to StartTLS rather than encrypted from the start, right? Hmmm... Overall learning about things still and can't decide yet on pressing merge or not.

consideRatio commented 2 months ago

SSL and TLS --- its confusing to say "use_ssl=False" and "use_tls=True" at the same time, and its also confusing to have TLS when use_ssl is false as we do now.

Argh.