jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
206 stars 178 forks source link

Fix broken tests for jupyterhub 5 #246

Closed consideRatio closed 2 months ago

consideRatio commented 2 months ago

I think maybe its related to allow_all config? Maybe not? For reference, see also: https://github.com/jupyterhub/firstuseauthenticator/pull/56.

minrk commented 2 months ago

Pretty sure this is due to allow_all config and the fact that allowed_groups is checked in authenticate and not check_allowed.