jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter

BSD 3-Clause "New" or "Revised" License

206 stars 178 forks source link

Support `allowed_users` and `admin_users` #260

Closed consideRatio closed 2 months ago

consideRatio commented 2 months ago

allowed_user and admin_users are config options from the Authenticator base class. They should work in this authenticator class as well, allowing usernames to be listed in order to be allowed access.

consideRatio commented 2 months ago

I think https://github.com/jupyterhub/ldapauthenticator/pull/269 is a step towards making sure that allowed_user and admin_users works more as expected, where for example users doesn't have to be listed both in a allowed group and individually in allowed_users.

minrk commented 2 months ago

269 actually doesn't fix allowed_users (yet) but it's a tiny change to do so. I'll make sure there's a test.

minrk commented 2 months ago

This is now fixed and tested by #269