jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
206 stars 178 forks source link

Add `tls_kwargs` config to configure underlying ldap3 package tls #273

Closed consideRatio closed 2 months ago

consideRatio commented 2 months ago

And together with #258, I think its fair to say this also...

I didn't want to add several separate config options of what can be configured in the ldap3 package through LDAPAuthenticator, so I instead added tls_kvargs and referenced ldap3 docs and source code for details. Like this we avoid maintenance and a layer that de-couples users from ldap3 which really does the work related to TLS anyhow.

consideRatio commented 2 months ago

@minrk I rebased, fixed a commit message, and changed kvargs to kwargs and mentions of a "key value pairs" was updated to "keyword arguments", and adjusted to use pytest.raises.

consideRatio commented 2 months ago

Thank you for reviewing @minrk!!!!!

minrk commented 2 months ago

Thank you!