jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
206 stars 178 forks source link

Change `use_lookup_dn_username` default value to False #280

Closed consideRatio closed 1 month ago

consideRatio commented 2 months ago

This default change (only relevant if lookup_dn=True) makes JupyterHub usernames end up what was entered into the login form, as compared to end up what was looked up from a found user's value of the attribute which name was configured via use_lookup_dn_username.

In practice, this can be the difference between getting JupyterHub usernames like philip j. fry (normalized from Philips J. Fry) and fry when entering the username fry when logging in.

I propose this breaking change because:

consideRatio commented 2 months ago

(force push was a rebase for #281)

consideRatio commented 1 month ago

Rebased again, I'll go for this and cut a beta2 updating and updating the changelog