jupyterhub / ldapauthenticator

LDAP Authenticator Plugin for Jupyter
BSD 3-Clause "New" or "Revised" License
206 stars 178 forks source link

tests: pass config to constructor instead of configuring after #281

Closed consideRatio closed 2 months ago

consideRatio commented 2 months ago

Our tests previously was written in a way what created a blank authenticator object, and then configured it one config at the time. I want to transition away from that, as it makes traitlets verification of config error if any of the incremental configuration steps after the authenticator object is initialized are invalid - even though the final configuration won't be.

By this change, we align better with how users are going to use their authentication class which is typically initialized by jupyterhub itself based on config provided, rather than initialized without provided config and then updated.