jupyterhub / mybinder.org-deploy

Deployment config files for mybinder.org
https://mybinder-sre.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
76 stars 74 forks source link

Update prometheus and ingress-nginx dependencies, multiple major versions behind #2182

Closed consideRatio closed 2 years ago

consideRatio commented 2 years ago

With #2180 we now have automation to do regular dependency bumps of our charts. But, at this point, we are several major versions behind for prometheus and ingress-nginx.

I've outlined steps for how to upgrade these:

minrk commented 2 years ago

upgrade our Ingress resources from v1beta1 to v1

I believe all of our ingresses are already v1. Is that not the case?

$ kubectl get ing -o yaml | grep apiVersion
apiVersion: v1
- apiVersion: networking.k8s.io/v1
- apiVersion: networking.k8s.io/v1
    - apiVersion: acme.cert-manager.io/v1alpha2
- apiVersion: networking.k8s.io/v1
- apiVersion: networking.k8s.io/v1
- apiVersion: networking.k8s.io/v1
- apiVersion: networking.k8s.io/v1
- apiVersion: networking.k8s.io/v1
consideRatio commented 2 years ago

Those directly part of the mybinder helm chart's templates are as of #2224 v1, but I bet there can be old resources generated by the use of old helm charts like prometheus.

Ah, you inspected all ingress resources in some namespace, so, if that namespace included prometheus of old version, we should be good. Otherwise, I was thinking we should also bump prometheus before dropping support for v1beta1.

minrk commented 2 years ago

Yup, that's all our ingress resources from this whole chart. And #2203 succeeded on staging, so going ahead with that one