search

jupyterhub / mybinder.org-deploy

Deployment config files for mybinder.org
https://mybinder-sre.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
76 stars 74 forks source link

Serve mybinder bagdes from static.mybinder.org #876

Open yuvipanda opened 5 years ago

yuvipanda commented 5 years ago

Serving badges from mybinder.org runs into privacy and cookie problems, which caused us to set up static.mybinder.org. Currently, we're again serving badges from mybinder.org - we should be serving them from static.mybinder.org instead.

https://github.com/jupyterhub/binderhub/issues/379 for previous time this happened.

yuvipanda commented 5 years ago

static.mybinder.org/badge.svg also doesn't seem to be working anymore?

Edit: Ah, nvm, it is.

yuvipanda commented 5 years ago

Apparently I misremembered - we were always sending them from mybinder.org - static was a place for other projects (specifically, sphinx gallery) to be able to load from. They can load badge_logo.svg too now.

https://github.com/jupyterhub/binderhub/issues/392 for making this configurable.

betatim commented 5 years ago

We need to update the code for https://mybinder.org/ as well

choldgraf commented 5 years ago

hmmm, do we have this documented somewhere? I'm a bit worried that @yuvipanda had to figure out what one of our subdomains was for :-) (I definitely would have had this problem as well)

yuvipanda commented 5 years ago

@choldgraf you filed #822 last time ;)