jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
151 stars 103 forks source link

[DOCS] Grafana charts not showing on the status page of mybinder.readthedocs.io #195

Closed sgibson91 closed 3 years ago

sgibson91 commented 4 years ago

Bug description

Hi all,

Just reporting that the grafana charts we show on https://mybinder.readthedocs.io/en/latest/status.html aren't showing up for me

Chrome:

Screenshot 2020-04-17 at 13 14 04

Firefox:

Screenshot 2020-04-17 at 13 13 48

Safari:

Screenshot 2020-04-17 at 13 13 41

Expected behaviour

Actual behaviour

How to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Your personal set up

manics commented 4 years ago

My Firefox web console (Tools ➡️ Web Developer ➡️ Web Console) shows these errors:

Load denied by X-Frame-Options: “deny” from “https://grafana.mybinder.org/d-solo/fLoQvRHmk/status?panelId=6&orgId=1&tab=general&theme=light”, site does not permit any framing. Attempted to load into “https://mybinder.readthedocs.io/en/latest/status.html”.

Load denied by X-Frame-Options: “deny” from “https://grafana.mybinder.org/d-solo/fLoQvRHmk/status?panelId=2&orgId=1&tab=general&theme=light”, site does not permit any framing. Attempted to load into “https://mybinder.readthedocs.io/en/latest/status.html”.

Load denied by X-Frame-Options: “deny” from “https://grafana.mybinder.org/d-solo/fLoQvRHmk/status?panelId=4&orgId=1&tab=general&theme=light”, site does not permit any framing. Attempted to load into “https://mybinder.readthedocs.io/en/latest/status.html”.

which suggests it has to be fixed on the Grafana side.

I think the last change to the Grafana version was https://github.com/jupyterhub/mybinder.org-deploy/pull/1195 on 12 Oct 2019.

manics commented 4 years ago

Do you want to give https://github.com/jupyterhub/mybinder.org-deploy/pull/1410 a go?

sgibson91 commented 4 years ago

Merged! Let's see if that solves anything 🤞

manics commented 4 years ago

Reopening since this is only on staging, not prod yet!