search

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
151 stars 103 forks source link

Add Docs for Binder Badge w/GitHub Actions #203

Closed hamelsmu closed 4 years ago

hamelsmu commented 4 years ago

Summary of changes made:

Thanks to @choldgraf for pair programming with me and getting me started.

cc: @betatim

Closes #202 (added by @consideRatio)

welcome[bot] commented 4 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

hamelsmu commented 4 years ago

@choldgraf stuck on this one, not sure how to resolve the readthedocs error, does anything stick out to you?

hamelsmu commented 4 years ago

Reposting this comment from @choldgraf as a reminder of TODO for myself:

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for a comment from anyone

hamelsmu commented 4 years ago

@choldgraf

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for comment from anyone

I addressed this with another example and more explanation. I didn't want to overly complicate the issue, so I provided the building blocks of how you can achieve this with a more simple example and let the user decide what to do themselves. What do you think?

hamelsmu commented 4 years ago

@consideRatio

there are still some open discussions not yet resolved

What is not resolved? Please let me know!

consideRatio commented 4 years ago

there are still some open discussions not yet resolved

Nothing any more, you quickly resolved them =) This LGTM! +1 for merge @choldgraf!

hamelsmu commented 4 years ago

Oh wait, maybe I messed up the title of this it is not supposed to be capitalized, it seems 🤦 my apologies

EDIT: ☝️ Fixed it 🎉 LOL

hamelsmu commented 4 years ago

@consideRatio I'm going to start calling you the "human" linter 🎉 I got to get whatever IDE plugins you are using! Sharp eye for spacing

consideRatio commented 4 years ago

Final fix so it doesn't get lost in the big thread: https://github.com/jupyterhub/binder/pull/203#pullrequestreview-450992778

hamelsmu commented 4 years ago

Final fix so it doesn't get lost in the big thread: #203 (review)

Fixed it in https://github.com/jupyterhub/binder/pull/203/commits/d72a4b274749651383d05a1577945180a838c93b

choldgraf commented 4 years ago

Alright this LGTM as well - thanks all for all of the helpful comments and iteration! And congrats @hamelsmu on figuring out how Sphinx works! You are in rarefied air 😅

Thanks for this contribution!

welcome[bot] commented 4 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

choldgraf commented 4 years ago

It's alive! https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html