jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
156 stars 103 forks source link

binder-badge can use new pull_request_target #206

Closed manics closed 4 years ago

manics commented 4 years ago

binder-badge.yml will now work with pull requests from forks, using the new pull_request_target. the action is also changed to use the commit sha instead of the branch name- since it's automatically run after every push to a PR this probably makes more sense than repeatedly posting a badge with the same branch name.

welcome[bot] commented 4 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

manics commented 4 years ago

See an example on https://github.com/manics/idr0083-sars-cov2-notebook/pull/5

@hamelsmu this uses pull_request_target: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

hamelsmu commented 4 years ago

Yep can confirm this works. This feature came out yesterday. Cheers

choldgraf commented 4 years ago

gah this is cool!

hamelsmu commented 4 years ago

@choldgraf can we merge this?

choldgraf commented 4 years ago

I don't know the infra on this one super well so am probably not best to say if (technically-speaking) it's good to merge, but I trust y'alls judgment 👍

hamelsmu commented 4 years ago

@choldgraf you are going to have to push the button, I don't have the permissions

choldgraf commented 4 years ago

🤦‍♂️ my bad!

welcome[bot] commented 4 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: