Binder badge: use repo.full_name

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.

https://mybinder.readthedocs.io

BSD 3-Clause "New" or "Revised" License

151 stars 103 forks source link

Binder badge: use repo.full_name #208

Closed manics closed 4 years ago

manics commented 4 years ago

GitHub Actor is the user that opened the PR, but this may not be the same as the owner of the fork. For example if you open a PR using an org branch, or if you open a PR using someone else's fork.

pull_request.head.repo.full_name should be the owner/reponame of the PR fork.

E.g. Compare the first (old workflow) and last (updated workflow) comments on https://github.com/manicstreetpreacher/test-binder-badge/pull/1

choldgraf commented 4 years ago

@hamelsmu does this look correct to you?

hamelsmu commented 4 years ago

Yeah this looks good to me