search

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
151 stars 103 forks source link

Point binder to the branch #217

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

I think it will make more sense to spin binder on the PR branch than on a PR commit.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 3 years ago

I think this makes perfect sense, given that this comment workflow is triggered on pull_request_target such as "Opened" rather every time there is a new commit. It would also make sense to make it only trigger on "Opened" rather than all of "opened", "assigned", "reopened", etc.

Thank you @fcollonval for contributing this improvement!

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: