search

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
151 stars 103 forks source link

Update custom Dockerfile section by adding a debugging section #231

Closed consideRatio closed 3 years ago

consideRatio commented 3 years ago

Updated PR (ready for merge)

This PR is transformed to a PR adding a debugging section, not a lot more. This is because my original PR attempt contained a section that I couldn't verify to be either correct or incorrect.

Original PR (outdated)

It isn't the first time I fail to understand what cause a Dockerfile to fail to launch on mybinder.org after it has successfully launched locally.

One of the reason this can happen is because the Dockerfile has a user with id 1000 with too much permissions. This is caused by us applying a k8s securityContext with allowPrivilegeEscalation set to false. Thankfully, this can be mimicked locally and this PR describes how to do that.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 3 years ago

I'm not sure i got it right about the --security-opt=no-new-privileges:true, need to consider it a bit longer.

choldgraf commented 3 years ago

@consideRatio please ping once you're ready for a review/merge - this looks good to me

betatim commented 3 years ago

LGTM. I am confused about reviewing a PR that is in draft mode. 👍 from me, modulo the comment I left where I think we could help out readers if we expand a bit.

consideRatio commented 3 years ago

@consideRatio please ping once you're ready for a review/merge - this looks good to me

Ping @choldgraf!

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: