Closed manics closed 3 years ago
If you're restricted your GITHUB_TOKEN to default to read-only you'll need extra permissions on the binder badge workflows. If you haven't restricted GITHUB_TOKEN this has no effect so might as well always include it.
GITHUB_TOKEN
binder-badge.yaml
binder-badge-permissions.yaml
I didn't update chatops-binder.yaml because I don't have somewhere to test it- does it need issues, pull-requests, or both?
chatops-binder.yaml
issues
pull-requests
Merged. Not sure about the chatops actions :-/
If you're restricted your
GITHUB_TOKEN
to default to read-only you'll need extra permissions on the binder badge workflows. If you haven't restrictedGITHUB_TOKEN
this has no effect so might as well always include it.binder-badge.yaml
change in https://github.com/jupyterhub/jupyter-remote-desktop-proxy/commit/5c46d99aa244b3a4e9a8df72e9703d4695900170 https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/6#issuecomment-825526604binder-badge-permissions.yaml
looks similar enough that it should work without testingI didn't update
chatops-binder.yaml
because I don't have somewhere to test it- does it needissues
,pull-requests
, or both?