jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
151 stars 103 forks source link

Mention possible location of configuration files in documentation #236

Closed astrojuanlu closed 3 years ago

astrojuanlu commented 3 years ago

This was mentioned in the repo2docker docs, but not on the binder ones.

In addition, I used this opportunity to enable intersphinx in the repository.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

astrojuanlu commented 3 years ago

Sphinx 4.0.3 got installed, which doesn't have the add_stylesheet method anymore.

On the other hand:

Traceback (most recent call last):
  File "federation/gen_federation.py", line 3, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'

Unsure how to continue 🤔

astrojuanlu commented 3 years ago

Oh I see, a couple of extensions pull sphinx>=2. Easy fix.

astrojuanlu commented 3 years ago

Rendered version: https://mybinder--236.org.readthedocs.build/en/236/config_files.html#configuration-files

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

choldgraf commented 3 years ago

looks great - thanks very much! :-)