search

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
150 stars 103 forks source link

minimal Dockerfile example yields broken notebook (404: not found) on mybinder.org #240

Open N-Coder opened 2 years ago

N-Coder commented 2 years ago

Opening any of the two binder links of the minimal Dockerfile example yields a notebook that simply displays a 404 error page: image Binder master branch Binder truly-minimal branch Running jupyter-repo2docker https://github.com/binder-examples/minimal-dockerfile locally yields a working notebook.

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

manics commented 2 years ago

That'll be due to the default URL changing to jupyterlab https://github.com/jupyterhub/binderhub/pull/1354

Options are to either change the binder badge to pass /tree as the starting URL, or to install JupyterLab in the minimal Dockerfile.

N-Coder commented 2 years ago

I also get the same problem when pasting the link to the GitHub repo on the mybinder.org starting page, so it's probably all links that are generated there: https://mybinder.org/v2/gh/binder-examples/minimal-dockerfile/HEAD image

betatim commented 2 years ago

mybinder.org will try to send you to the URL at which JupyterLab is, but because the minimal example doesn't install JupyterLab you get a 404. This means that the minimal example needs updating so that it installs Jupyter Lab. Do you want to tackle that in a PR to https://github.com/binder-examples/minimal-dockerfile?

N-Coder commented 2 years ago

So that basically means that Docker Containers without JupyterLab are no longer really supported on mybinder.org? I guess then there are also some parts of the documentation that should be updated to reflect this, especially here and here. One could either remove the part about only installing notebook or make the information about how to switch between both versions more promininent with a warning on both pages saying that you'll need to manually fix your URLs.

betatim commented 2 years ago

So that basically means that Docker Containers without JupyterLab are no longer really supported on mybinder.org?

Not quite. You can make a container that doesn't have lab installed but then you will have to specify the URL that users should be redirected to because the default URL is the one JupyterLab uses.

Yes, there are unfortunately a lot of places in the docs that need updating that haven't yet been updated.

N-Coder commented 2 years ago

I opened PRs in #243, binder-examples/minimal-dockerfile#4 and binder-examples/minimal-dockerfile#5, feel free to edit them as you deem suitable. I also didn't update the example overview page, as that probably needs the other PRs merged and I currently have no environment at hand to actually run the script.