search

jupyterhub / mybinder.org-user-guide

Turn a Git repo into a collection of interactive notebooks. This is Binder's user documentation repository.
https://mybinder.readthedocs.io
BSD 3-Clause "New" or "Revised" License
150 stars 103 forks source link

ci: stop test build of docs on circleci, update RTD config #250

Closed consideRatio closed 2 years ago

consideRatio commented 2 years ago

We have been using CircleCI alongside RTD to run tests, and now we got an error on CircleCI because it was using python 3.6 that was no longer compatible with a package we installed.

So, I'm removing that duplicated CI logic in circleci in favor of relying on the test builds now supported by RTD, which is also responsible for building/publishing.

This should resolve the build error observed in #249.

consideRatio commented 2 years ago

Thanks @sgibson91!

manics commented 2 years ago

Don't forget to disable the CircleCI build in https://app.circleci.com/projects/project-dashboard/github/jupyterhub/ when removing it from future projects to avoid an error status or PRs :smile:

consideRatio commented 2 years ago

@manics ah I didn't know about that part, thanks!