Add slash restriction to username validation

jupyterhub / nativeauthenticator

JupyterHub-native User Authenticator

https://native-authenticator.readthedocs.io

BSD 3-Clause "New" or "Revised" License

72 stars 69 forks source link

Add slash restriction to username validation #197

Closed marc-marcos closed 2 years ago

marc-marcos commented 2 years ago

Documentation said that spaces, commas and slasher weren't allowed but only the restriction of commas and spaces was enforced.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

lambdaTotoro commented 2 years ago

Hi! Thanks for your pull request!

To close #196, it would also be necessary to adapt the error messages in the SignupHandler.

marc-marcos commented 2 years ago

Didn't push that, give me a sec.

lambdaTotoro commented 2 years ago

Great. That looks good, then.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: