search

jupyterhub / nativeauthenticator

JupyterHub-native User Authenticator
https://native-authenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
72 stars 69 forks source link

Main branch tests are broken with jupyterhub 1.5.1 and sqlalchemy 1 #253

Closed consideRatio closed 2 weeks ago

consideRatio commented 1 year ago

https://github.com/jupyterhub/nativeauthenticator/actions/runs/5726269868/job/15516371917

Run pytest --maxfail=2 --cov=nativeauthenticator
ImportError while loading conftest '/home/runner/work/nativeauthenticator/nativeauthenticator/nativeauthenticator/tests/conftest.py'.
nativeauthenticator/tests/conftest.py:2: in <module>
    from jupyterhub.tests.mocking import MockHub
/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/jupyterhub/tests/mocking.py:49: in <module>
    from ..singleuser import SingleUserNotebookApp
/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/jupyterhub/singleuser/__init__.py:5: in <module>
    from .app import main
/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/jupyterhub/singleuser/app.py:[16](https://github.com/jupyterhub/nativeauthenticator/actions/runs/5726269868/job/15516371917#step:6:17): in <module>
    App = import_item(JUPYTERHUB_SINGLEUSER_APP)
/opt/hostedtoolcache/Python/3.8.[17](https://github.com/jupyterhub/nativeauthenticator/actions/runs/5726269868/job/15516371917#step:6:18)/x64/lib/python3.8/site-packages/traitlets/utils/importstring.py:30: in import_item
    module = __import__(package, fromlist=[obj])
E   ModuleNotFoundError: No module named 'notebook.notebookapp'
Error: Process completed with exit code 4.
consideRatio commented 1 year ago

I think its an option to drop support for jupyterhub v1 and maybe more as a resolution as well.

consideRatio commented 2 weeks ago

Resolved by dropping support for JH1-3