jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

nbgitpuller link generator: Repo name doesn't get properly populated for Binder links using a Custom URL for "Application to Open" #230

Open sgibson91 opened 3 years ago

sgibson91 commented 3 years ago

Bug description

Hello! I've been playing around with the nbgitpuller link generator for one of my projects and I noticed that when I try to use a Custom URL to open my notebook in (in this case, a rendered Voila dashboard), the repo name doesn't get properly populated in the link, instead showing "undefined". I think this bug is restricted to just the Binder panel.

Expected behaviour

I expect the repo name to be properly populated in the nbgitpuller link, like in this example when I choose the Classic Notebook interface.

expected_behaviour

Actual behaviour

"undefined" is being populated as the name of the repo in the nbgitpuller link when generated using a Custom URL for Binder links

incorrect_nbgitpuller_link

How to reproduce

  1. Go to https://jupyterhub.github.io/nbgitpuller/link.html
  2. Click on the Binder panel
  3. Fill in the form with some dummy values
  4. Select "Custom URL" for "Application to Open" and fill in a dummy value
  5. See error in the generated link

Your personal set up

welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: