search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

Support building on mybinder.org to ease testing #258

Open manics opened 2 years ago

manics commented 2 years ago

At the moment if you want to test a PR that affects the UI you need to clone the PR and install it locally. In many cases testing on mybinder.org is good enough, the main exceptions are some interactions which are dependent on whether jupyter-notebook or jupyter-server is used.

consideRatio commented 2 years ago

Can you make it a .binder folder, and add an inline comment in the requirements.txt file that this is to help us start the repo at mybinder.org for UI testing purposes?

consideRatio commented 1 year ago

I implemented the changes I suggested and force pushed a rebase. Instead of binder/requirements, its not .binder/requirements.txt with an inline comment about its purpose.

@manics wdyt about this PR as it is now?

I noted that I could get nbgitpuller started without having .binder/requirements.txt, which made sense to me as i believe repo2docker will detect setup.py etc and install this directly.