search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

Release to fix regression introduced by #257 #281

Closed albertmichaelj closed 2 years ago

albertmichaelj commented 2 years ago

A late pull request in the most recent release of nbgitpuller (pull request #257) re-introduced an old bug (see issue #106). This was due to an attempt to fix a bug that my pull request that fixed #106 inadvertently introduced (see #234). The author of #257 (@jdmansour) realized the bug was re-introduced and fixed it (correctly this time) in a subsequent pull request (see #264). Unfortunately, the fix doesn't seem to have made it into a release, I think due to waiting on pull request #269, which has since been merged.

The regression introduced in #257 is fairly serious for how I use nbgitpuller, and I had to downgrade to get it around it. Given that the fix is already in main, would it be possible to make a point release in order to ensure that the most recent released version does not include this bug?

farcila commented 2 years ago

@albertmichaelj we are facing the same issue for our use-case, did the downgrade to 1.0.2 work for you fine?

albertmichaelj commented 2 years ago

@farcila It's only the most recent release that has the bug, so downgrading to 1.0.2 works fine. I think there are other bugs that 1.1.0 fixed, but those are bugs that I don't run into with the way I use nbgitpuller.

yuvipanda commented 2 years ago

@albertmichaelj would you be willing to follow the process in https://github.com/jupyterhub/nbgitpuller/blob/main/RELEASE.md and make a release? I'd be happy to give you the rights to do so, and it'll help ease the burden on current maintainers.

albertmichaelj commented 2 years ago

@yuvipanda I apologize for the delay in my response. I would be happy to make a new release. I assume that before I do that I need to update the changelog? Is that the only thing that needs to be done before I follow the directions in the release? If so, I'll work on creating a pull request with the updated changelog, and then after the pull request is merged, I can make the release. Let me know if I've missed something.

yuvipanda commented 2 years ago

@albertmichaelj yep, a changelog PR would be great!

consideRatio commented 2 years ago

This projects RELEASE.md isn't fully updated, please use github-activity and make use of notes in https://github.com/jupyterhub/team-compass/issues/563 with regards to how to do it.

Thank you for your help @albertmichaelj!!!

albertmichaelj commented 2 years ago

Sorry for the long delay. I have been teaching, and this fell down the priority list. I just submitted a pull request (#282) with an updated changelog and incremented version number. Since I don't have write access to the repo, I can't go all the way through to pushing the changes and setting the tag. Please let me know if I didn't do something right, and I'm happy to take another stab at it.

yuvipanda commented 2 years ago

@albertmichaelj I've just invited you to this repo so you can do the full honors!

albertmichaelj commented 2 years ago

Done! Thanks for letting me help out in this way!