search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
205 stars 84 forks source link

Make tests work with different default branch, or different locale #284

Closed jdmansour closed 1 year ago

jdmansour commented 1 year ago

This is a fix for #283. If the user changed the default branch name on their system, the tests would fail.

At the same time, I noticed some tests fail on my laptop with a German OS (LANG=de_DE.UTF-8). This is because we parse the output of git, which is different if the locale is not set to English. (Now that I think about it, it doesn't just affect the tests and is an actual bug, but I still left it in this PR because it is just a one-liner.)

yuvipanda commented 1 year ago

One suggestion, happy to merge after that, @jdmansour.

yuvipanda commented 1 year ago

Thanks a lot, @jdmansour!