search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

nbgitpuller binder link generator not working with repos other than GitHub.com #286

Open fkohrt opened 1 year ago

fkohrt commented 1 year ago

Bug description

The nbgitpuller link generator makes it look like you can enter any "Git Environment Repository URL", while in fact no working links are generated for GitLab.com repositories.

Expected behaviour

Either a correct label such as GitHub Environment Repository URL or actually working links.

Actual behaviour

If I enter e.g. https://gitlab.com/fkohrt/RMarkdown-sandbox and some content repository (e.g. https://github.com/binder-examples/r), the resulting link starts with https://mybinder.org/v2/gh/ instead of https://mybinder.org/v2/gl/ and does not turn fkohrt/RMarkdown-sandbox into fkohrt%2FRMarkdown-sandbox

yuvipanda commented 1 year ago

Thanks for opening this! This only applies to the binder tab, right?

fkohrt commented 1 year ago

I never used the other tabs so I don't know if they have a similar issue, I noticed it when using the Binder tab.

Also I just noticed that this is not limited to GitLab.com, but in fact applies to all providers other than GitHub.com. Here's a small collection of repos that work with mybinder.org but not with the nbgitpuller link generator:

GitLab (Framagit)

Gitea (Codeberg)

Sourcehut

Note that actually launching Sourcehut repos currently does not seem to work, see jupyterhub/binderhub#1590.

Bitbucket