jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

nbgitpuller chrome extension not working when pulling branches other than main #289

Open rohanjha123 opened 1 year ago

rohanjha123 commented 1 year ago

The nbgitpuller doesn't generate the right link when pulling branches other than main. When I tried pulling this file to data100.datahub.berkeley.edu using the chrome extension, the load failed. However, when I manually input all the info here and tried again, the pull succeeded, causing me to believe it's an issue with the chrome extension. A photo of the manual input can be seen below.

Screen Shot 2023-01-29 at 11 21 46 AM

Expected behaviour

The link loads properly

Actual behaviour

The chrome extension file redirect doesn't load properly. Instead, the following error message pops up

Screen Shot 2023-01-29 at 11 16 27 AM

How to reproduce

Use the chrome extension to generate a nbgitpuller link for this file

Your personal set up

Full environment The full environment can be found [here](https://github.com/DS-100/datahub/blob/staging/deployments/data100/image/environment.yml) and [here](https://github.com/DS-100/datahub/blob/staging/deployments/data100/image/infra-requirements.txt).
Configuration ```python # jupyterhub_config.py ```
Logs ``` # paste relevant logs here, if any ```
welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

balajialg commented 1 year ago

@yuvipanda FYI!

rohanjha123 commented 1 year ago

Friendly reminder @yuvipanda! Fixing this issue will be very helpful for the data 100 testing workflow

yuvipanda commented 1 year ago

Hi @balajialg and @rohanjha123! Unfortunately I don't think I have time to look into this right now :( However, if you can make a PR to the repo (which is at https://github.com/yuvipanda/nbgitpuller-link-generator-webextension), I can take a look. Otherwise it might be a while before I can look at this.

balajialg commented 1 year ago

@yuvipanda Thanks. I will sync up with @rohanjha123 to figure out ways to create PR to this repo.

ericvd-ucb commented 1 year ago

@rohanjha123 @balajialg - i am gonna make a comment on Webextension where you should be able to make the PR

https://github.com/yuvipanda/nbgitpuller-link-generator-webextension/issues/1