search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
205 stars 84 forks source link

avoid deprecation warnings in test_api teardown #301

Closed minrk closed 1 year ago

minrk commented 1 year ago

replaces nose-style teardown with a fixture

tests are unchanged, but diff is large because it's mostly dedented.

yuvipanda commented 1 year ago

@minrk hmm, any idea why all the tests are failing everywhere?

consideRatio commented 1 year ago

Test failures in main for 3 weeks: https://github.com/jupyterhub/nbgitpuller/actions/workflows/test.yml?query=branch%3Amain

minrk commented 1 year ago

I wasn't able to reproduce it locally, and noticed there's been a git release (2.40). It's a change in behavior between git 2.39.2 and 2.40 which apparently changed what's a resolvable conflict. I can't seem to find the changelog for git itself to track it down.

minrk commented 1 year ago

302 fixes the failure with git 2.40

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: