Don't hardcode 'master' into the link generator

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path

https://nbgitpuller.readthedocs.io

BSD 3-Clause "New" or "Revised" License

212 stars 86 forks source link

Don't hardcode 'master' into the link generator #337

Open yuvipanda opened 10 months ago

yuvipanda commented 10 months ago

Just leaving it empty now checks out HEAD, which is the default branch.

Fixes https://github.com/jupyterhub/nbgitpuller/issues/311

manics commented 10 months ago

It looks like the Binder tab stlil requires a branch, do you consider this within the scope of this PR?

https://nbgitpuller--337.org.readthedocs.build/en/337/link.html

yuvipanda commented 10 months ago

@manics ah damn, it looks like the environment repository branch in the binder generated is actually reused to in the default generator. This sucks, because they both actually need different behavior - mybinder.org understands HEAD, but nbgitpuller does not. Ugh...