search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
212 stars 86 forks source link

Update style-sheet links to reflect those from `jupyter-server` #359

Closed possiblyMikeB closed 3 days ago

possiblyMikeB commented 1 month ago

At some point the jupyter-server project switched from including a combined style-sheet in their page.html template to including three distinct style-sheets.

This pull request changes the head block of the template page.html packaged with nbgitpuller to be consistent with the template of the same name from the jupyter-server package.

This change resolves https://github.com/jupyterhub/nbgitpuller/issues/358

agoose77 commented 3 days ago

@possiblyMikeB thank you for this PR!

@sgibson91 and I confirmed that this fixes #358.^review Your fix pulls in the dependencies for styling from the upstream jupyter-server. As of the time of writing, Jupyter Server ships these files for all versions of jupyter-server supported by nbgitpuller.

This may change in the future, and we think that another PR down the road should look at bundling bootstrap (or dropping it entirely) into nbgitpuller.

For now, this LGTU (looks good to us!)