search

jupyterhub / oauthenticator

OAuth + JupyterHub Authenticator = OAuthenticator
https://oauthenticator.readthedocs.io
BSD 3-Clause "New" or "Revised" License
414 stars 365 forks source link

[GitLab] GITLAB_URL should be read from the configuration instead of (or in addition to) the environment #462

Closed dvandok closed 1 year ago

dvandok commented 3 years ago

Bug description

When setting up the gitlab authenticator with a private giltab instance, the base URL of that instance needs to be passed to the software. The way it is set up right now is by reading GITLAB_URL from the environment, where other information (such as the client secret) are read from the configuration. This is annoying because when jupyterlab runs as a service under systemd, this requires tweaking of the service environment. This should not be necessary.

Expected behaviour

Setting up jupyterhub with a private gitlab instance for oauth, the gitlab_url should be set in the configuration.

Actual behaviour

The GITLAB_URL can only be passed in the enviromnent.

Your personal set up

We're running TLJH on a server for multiple users, authenticated against our own gitlab server.

I currently use a patched version of gitlab.py that addresses this issue; if you are interested I could share that.

welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

dvandok commented 3 years ago

I notice a lot of difference between the TLJH code I have deployed and what is current on Github, so the issue may already have been dealt with...

consideRatio commented 1 year ago

I see in https://github.com/jupyterhub/oauthenticator/blob/6bf2d22b119ea60a96579be4fb86690288ceaebc/oauthenticator/gitlab.py#L44 that this is configurable already, so I presume this is related to TLJH previously using an older version of this package.